-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasmota: Add more temp devices #1570
Tasmota: Add more temp devices #1570
Conversation
Codecov ReportBase: 96.77% // Head: 96.70% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1570 +/- ##
==========================================
- Coverage 96.77% 96.70% -0.07%
==========================================
Files 654 648 -6
Lines 9662 9352 -310
==========================================
- Hits 9350 9044 -306
+ Misses 312 308 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
1d02108
to
063fa01
Compare
063fa01
to
11fc56e
Compare
11fc56e
to
31da0c3
Compare
Looks fine for me, maybe can you ask for testers on the forum? |
Just asking Not using global match is for filtering device_temperature feature, right ? Reference post: https://community.gladysassistant.com/t/thr320-sonoff-tasmota-resolution-problemes/7495/12?u=vonox |
31da0c3
to
e8b7f31
Compare
I just rebase it on master. @Pierre-Gilles I am generating an up-to-date Docker image, I will ask for testers. |
e8b7f31
to
728d371
Compare
728d371
to
987f672
Compare
Job #517: Bundle Size — 7.02MB (0%).Changed assets by type (0/7)
|
* Add BL09XX temp devices * Add ESP32 temp devices * Add DS18x20 temp device * Generic temp/humidity discover
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Allow BL09XX, DS18x20 and ESP32 temperature features from Tasmota service.
According to the subjects