Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing integrations in integrations view + add open-zwave deprecated warning #1579

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review July 29, 2022 12:34
@Pierre-Gilles Pierre-Gilles changed the title Add missing integrations in integrations view Add missing integrations in integrations view + add open-zwave deprecated warning Jul 29, 2022
@relativeci
Copy link

relativeci bot commented Jul 29, 2022

Job #408: Bundle Size — 6.84MB (+1.25%).

e12be39 vs f262ea1

Changed metrics (4/10)
Metric Current Baseline
Initial JS 2.88MB(+0.41%) 2.87MB
Cache Invalidation 43.14% 0%
Assets 144(+2.13%) 141
Modules 1259(+0.24%) 1256
Changed assets by type (2/7)
            Current     Baseline
IMG 1.55MB (+4.89%) 1.48MB
JS 4.87MB (+0.25%) 4.86MB

View Job #408 report on app.relative-ci.com

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1579 (cb3fd9a) into master (f262ea1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1579   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         630      630           
  Lines        9267     9267           
=======================================
  Hits         8956     8956           
  Misses        311      311           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@atrovato atrovato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great enough, but do we want to have these integrations in device category? Or in a "third parties" category? or else?

Another point, some descriptions are on one line, some on 2.

image

@Pierre-Gilles
Copy link
Contributor Author

@atrovato You're right, I'm moving Google Home / Alexa into the "communication" tab, it's better.

For the description line, I'm going to write longer descriptions for other integrations :D

@Pierre-Gilles
Copy link
Contributor Author

localhost_1444_dashboard_integration

@Pierre-Gilles Pierre-Gilles merged commit e12be39 into master Aug 4, 2022
@Pierre-Gilles Pierre-Gilles deleted the add-missing-integrations branch August 4, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants