Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opening sensor icon #1589

Merged

Conversation

vincentBesseau
Copy link
Contributor

@vincentBesseau vincentBesseau commented Aug 14, 2022

I just changed opening sensor icon following what has been said here

image

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #1589 (ac58e6a) into master (58aeb37) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1589      +/-   ##
==========================================
+ Coverage   96.59%   96.64%   +0.05%     
==========================================
  Files         616      630      +14     
  Lines        8887     9267     +380     
==========================================
+ Hits         8584     8956     +372     
- Misses        303      311       +8     
Impacted Files Coverage Δ
server/lib/gateway/gateway.checkIfBackupNeeded.js 81.81% <0.00%> (-6.42%) ⬇️
server/lib/device/device.calculateAggregate.js 90.00% <0.00%> (-4.00%) ⬇️
server/utils/colors.js 100.00% <0.00%> (ø)
server/services/index.js 100.00% <0.00%> (ø)
server/lib/event/index.js 100.00% <0.00%> (ø)
server/utils/constants.js 100.00% <0.00%> (ø)
server/lib/gateway/index.js 100.00% <0.00%> (ø)
server/lib/service/index.js 100.00% <0.00%> (ø)
server/config/scheduler-jobs.js 100.00% <0.00%> (ø)
server/models/device_feature.js 100.00% <0.00%> (ø)
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@VonOx VonOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pierre-Gilles this can be merged

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works fine! Thanks for your PR 🙏

@Pierre-Gilles Pierre-Gilles merged commit ac635bb into GladysAssistant:master Sep 8, 2022
@relativeci
Copy link

relativeci bot commented Sep 8, 2022

Job #435: Bundle Size — 6.84MB (~-0.01%).

ac635bb vs ce21420

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 58.66% 41.99%
Changed assets by type (1/7)
            Current     Baseline
JS 4.87MB (~-0.01%) 4.87MB

View Job #435 report on app.relative-ci.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants