Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1 dec place to RoomTemperaturBox #1594

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Sep 7, 2022

Description of change

image

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Base: 96.64% // Head: 96.64% // No change to project coverage 👍

Coverage data is based on head (494c711) compared to base (ce21420).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1594   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         630      630           
  Lines        9267     9267           
=======================================
  Hits         8956     8956           
  Misses        311      311           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VonOx VonOx requested a review from Pierre-Gilles September 7, 2022 09:07
@VonOx VonOx added enhancement effort:low Tasks lower than 2 hours to develop labels Sep 7, 2022
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works fine, thanks for your PR ! 🙏

@Pierre-Gilles Pierre-Gilles merged commit 4efe376 into GladysAssistant:master Sep 8, 2022
@relativeci
Copy link

relativeci bot commented Sep 8, 2022

Job #436: Bundle Size — 6.84MB (~+0.01%).

4efe376 vs ac635bb

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 58.2% 58.66%
Changed assets by type (1/7)
            Current     Baseline
JS 4.87MB (~+0.01%) 4.87MB

View Job #436 report on app.relative-ci.com

@VonOx VonOx deleted the add-dec-place-room-temp branch December 14, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:low Tasks lower than 2 hours to develop enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants