Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enedis integration #1597

Merged
merged 45 commits into from
Apr 10, 2023
Merged

Add Enedis integration #1597

merged 45 commits into from
Apr 10, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 9, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.

Usage

Screenshot 2023-02-06 at 09 58 25

Screenshot 2023-02-06 at 09 58 45

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Patch coverage: 99.15% and project coverage change: +0.01 🎉

Comparison is base (145e9b7) 97.56% compared to head (e6f90dc) 97.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
+ Coverage   97.56%   97.58%   +0.01%     
==========================================
  Files         653      662       +9     
  Lines        9948    10053     +105     
==========================================
+ Hits         9706     9810     +104     
- Misses        242      243       +1     
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <ø> (ø)
server/services/enedis/lib/enedis.sync.js 97.14% <97.14%> (ø)
server/lib/device/device.saveHistoricalState.js 100.00% <100.00%> (ø)
...ay/enedis/gateway.enedisGetConsumptionLoadCurve.js 100.00% <100.00%> (ø)
...ateway/enedis/gateway.enedisGetDailyConsumption.js 100.00% <100.00%> (ø)
...nedis/gateway.enedisGetDailyConsumptionMaxPower.js 100.00% <100.00%> (ø)
server/lib/gateway/index.js 100.00% <100.00%> (ø)
server/services/enedis/api/enedis.controller.js 100.00% <100.00%> (ø)
server/services/enedis/index.js 100.00% <100.00%> (ø)
server/services/enedis/lib/enedis.init.js 100.00% <100.00%> (ø)
... and 3 more

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 21, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e6f90dc
Status: ✅  Deploy successful!
Preview URL: https://1d02abd9.gladys-plus.pages.dev
Branch Preview URL: https://add-enedis-setup-screen.gladys-plus.pages.dev

View logs

@stale
Copy link

stale bot commented Dec 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 20, 2022
@stale stale bot closed this Dec 27, 2022
@Pierre-Gilles Pierre-Gilles reopened this Jan 2, 2023
@stale stale bot removed the stale label Jan 2, 2023
@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review February 6, 2023 04:24
@relativeci
Copy link

relativeci bot commented Feb 6, 2023

Job #1235: Bundle Size — 7.43MiB (+3.07%).

706d2b1(current) vs 827bce8 master#1231(baseline)

⚠️ Bundle contains 5 duplicate packages
⚠️ Bundle introduced one new package: bluebird

Metrics (6 changes)
                 Current
Job #1235
     Baseline
Job #1231
Initial JS 4.4MiB(+4.39%) 4.22MiB
Initial CSS 300.27KiB 300.27KiB
Cache Invalidation 59.8% 0%
Chunks 51 51
Assets 151(+1.34%) 149
Modules 1308(+0.46%) 1302
Duplicate Modules 20 20
Duplicate Code 0.78%(-3.7%) 0.81%
Packages 117(+0.86%) 116
Duplicate Packages 4 4
Total size by type (3 changes)
                 Current
Job #1235
     Baseline
Job #1231
CSS 313.4KiB 313.4KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.69MiB (+2.14%) 1.66MiB
JS 5.31MiB (+3.62%) 5.13MiB
Media 0B 0B
Other 15.88KiB (+0.9%) 15.74KiB

View job #1235 reportView master branch activity

@Pierre-Gilles Pierre-Gilles changed the title Add Enedis setup screen + Enedis local API Enedis integration Feb 6, 2023
@Pierre-Gilles Pierre-Gilles changed the title Enedis integration Add Enedis integration Feb 6, 2023
@Pierre-Gilles Pierre-Gilles merged commit 706d2b1 into master Apr 10, 2023
@Pierre-Gilles Pierre-Gilles deleted the add-enedis-setup-screen branch April 10, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant