Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Add new saveHistoricalState function + event #1613

Merged
merged 6 commits into from
Oct 10, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Oct 4, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add a new function + event to send historical state to Gladys

this.gladys.event.emit(EVENTS.DEVICE.NEW_STATE, {
     device_feature_external_id: 'hue:binary:1',
     state: 12,
     created_at: '2022-10-04T04:25:50.835Z',
});

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review October 4, 2022 04:24
@Pierre-Gilles Pierre-Gilles requested a review from atrovato October 4, 2022 04:27
@Pierre-Gilles Pierre-Gilles mentioned this pull request Oct 4, 2022
9 tasks
@Pierre-Gilles Pierre-Gilles changed the title Core: Add new saveHistoricalState function Core: Add new saveHistoricalState function + event Oct 4, 2022
@relativeci
Copy link

relativeci bot commented Oct 4, 2022

Job #553: Bundle Size — 7.03MB (0%).

648f5ff(current) vs 71d9a60 master#552(baseline)

Metrics (no changes)
                 Current
Job #553
     Baseline
Job #552
Initial JS 2.99MB 2.99MB
Initial CSS 294.38KB 294.38KB
Cache Invalidation 0% 0%
Chunks 50 50
Assets 145 145
Modules 1280 1280
Duplicate Modules 20 20
Duplicate Code 0.52% 0.52%
Packages 124 124
Duplicate Packages 10 10
Total size by type (no changes)
                 Current
Job #553
     Baseline
Job #552
CSS 312.36KB 312.36KB
Fonts 93.55KB 93.55KB
HTML 13.58KB 13.58KB
IMG 1.62MB 1.62MB
JS 5MB 5MB
Media 0B 0B
Other 4.59KB 4.59KB

View job #553 reportView master branch activity

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 96.74% // Head: 96.75% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1c2dfa1) compared to base (8eb46b2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
+ Coverage   96.74%   96.75%   +0.01%     
==========================================
  Files         649      650       +1     
  Lines        9388     9430      +42     
==========================================
+ Hits         9082     9124      +42     
  Misses        306      306              
Impacted Files Coverage Δ
server/lib/device/device.newStateEvent.js 81.81% <100.00%> (+4.04%) ⬆️
server/lib/device/device.saveHistoricalState.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles merged commit 648f5ff into master Oct 10, 2022
@Pierre-Gilles Pierre-Gilles deleted the add-save-historical-state-function branch October 10, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant