Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature parser #1614

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Oct 9, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix Tasmota temperature feature parser: https://community.gladysassistant.com/t/besoin-de-vous-un-nouvel-affichage-dashboard-des-noms-dappareils-pour-les-appareils-complexe/7559/26?u=alextrovato

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 96.74% // Head: 96.74% // No change to project coverage 👍

Coverage data is based on head (1719b6a) compared to base (3ec8d33).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1614   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         649      649           
  Lines        9388     9388           
=======================================
  Hits         9082     9082           
  Misses        306      306           
Impacted Files Coverage Δ
...erver/services/tasmota/lib/features/temperature.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles merged commit 71d9a60 into GladysAssistant:master Oct 10, 2022
@relativeci
Copy link

relativeci bot commented Oct 10, 2022

Job #552: Bundle Size — 7.03MB (0%).

71d9a60(current) vs ab87685 master#549(baseline)

Metrics (no changes)
                 Current
Job #552
     Baseline
Job #549
Initial JS 2.99MB 2.99MB
Initial CSS 294.38KB 294.38KB
Cache Invalidation 0% 0%
Chunks 50 50
Assets 145 145
Modules 1280 1280
Duplicate Modules 20 20
Duplicate Code 0.52% 0.52%
Packages 124 124
Duplicate Packages 10 10
Total size by type (no changes)
                 Current
Job #552
     Baseline
Job #549
CSS 312.36KB 312.36KB
Fonts 93.55KB 93.55KB
HTML 13.58KB 13.58KB
IMG 1.62MB 1.62MB
JS 5MB 5MB
Media 0B 0B
Other 4.59KB 4.59KB

View job #552 reportView master branch activity

@atrovato atrovato deleted the tasmota-SI7021 branch March 18, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants