Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Open-Zwave integration #1617

Merged
merged 6 commits into from
Nov 28, 2022
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Oct 10, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

Description of change

Remove deprecated Open-Zwave integration and add a screen to help user migrate

Screenshot 2022-11-28 at 11 02 34

@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 96.81% // Head: 97.22% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (0ad351a) compared to base (fbef01e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
+ Coverage   96.81%   97.22%   +0.40%     
==========================================
  Files         662      632      -30     
  Lines        9647     9298     -349     
==========================================
- Hits         9340     9040     -300     
+ Misses        307      258      -49     
Impacted Files Coverage Δ
server/services/index.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles changed the title WIP: Remove Open-Zwave integration Remove Open-Zwave integration Oct 14, 2022
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0ad351a
Status: ✅  Deploy successful!
Preview URL: https://d244c8c3.gladys-plus.pages.dev
Branch Preview URL: https://remove-open-zwave-integratio.gladys-plus.pages.dev

View logs

@Pierre-Gilles Pierre-Gilles marked this pull request as ready for review November 28, 2022 04:26
@relativeci
Copy link

relativeci bot commented Nov 28, 2022

Job #787: Bundle Size — 6.95MiB (-0.82%).

06dc8b6(current) vs fbef01e master#778(baseline)

Metrics (4 changes)
                 Current
Job #787
     Baseline
Job #778
Initial JS 3.01MiB(-1.88%) 3.06MiB
Initial CSS 294.83KiB(-0.01%) 294.87KiB
Cache Invalidation 47.69% 43.58%
Chunks 52 52
Assets 148 148
Modules 1235(-1.36%) 1252
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 106 106
Duplicate Packages 8 8
Total size by type (2 changes)
                 Current
Job #787
     Baseline
Job #778
CSS 312.8KiB (-0.01%) 312.84KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.89MiB (-1.16%) 4.95MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #787 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit 06dc8b6 into master Nov 28, 2022
@Pierre-Gilles Pierre-Gilles deleted the remove-open-zwave-integration branch November 28, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant