Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint check on it.only/describe.only #1621

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@relativeci
Copy link

relativeci bot commented Oct 14, 2022

Job #577: Bundle Size — 7.03MiB (0%).

3fd42c5(current) vs ef9bde5 master#558(baseline)

Metrics (no changes)
                 Current
Job #577
     Baseline
Job #558
Initial JS 2.99MiB 2.99MiB
Initial CSS 294.38KiB 294.38KiB
Cache Invalidation 0% 0%
Chunks 50 50
Assets 145 145
Modules 1280 1280
Duplicate Modules 20 20
Duplicate Code 0.52% 0.52%
Packages 124 124
Duplicate Packages 10 10
Total size by type (no changes)
                 Current
Job #577
     Baseline
Job #558
CSS 312.36KiB 312.36KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.62MiB 1.62MiB
JS 5MiB 5MiB
Media 0B 0B
Other 4.59KiB 4.59KiB

View job #577 reportView master branch activity

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 96.76% // Head: 96.76% // No change to project coverage 👍

Coverage data is based on head (ce3da91) compared to base (ef9bde5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1621   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files         650      650           
  Lines        9445     9445           
=======================================
  Hits         9139     9139           
  Misses        306      306           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles merged commit 3fd42c5 into master Oct 14, 2022
@Pierre-Gilles Pierre-Gilles deleted the add-it-only-check branch October 14, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant