Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refresh bug when changing dashboard with same boxs #1622

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@relativeci
Copy link

relativeci bot commented Oct 17, 2022

Job #597: Bundle Size — 7.05MiB (~+0.01%).

7378e01(current) vs 078e1f8 master#585(baseline)

Metrics (1 change)
                 Current
Job #597
     Baseline
Job #585
Initial JS 3MiB 3MiB
Initial CSS 294.57KiB 294.57KiB
Cache Invalidation 58.26% 0%
Chunks 50 50
Assets 145 145
Modules 1282 1282
Duplicate Modules 21 21
Duplicate Code 0.58% 0.58%
Packages 124 124
Duplicate Packages 10 10
Total size by type (1 change)
                 Current
Job #597
     Baseline
Job #585
CSS 312.54KiB 312.54KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.62MiB 1.62MiB
JS 5.02MiB (~+0.01%) 5.02MiB
Media 0B 0B
Other 4.59KiB 4.59KiB

View job #597 reportView master branch activity

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 96.76% // Head: 96.76% // No change to project coverage 👍

Coverage data is based on head (5b610b3) compared to base (078e1f8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1622   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files         650      650           
  Lines        9455     9455           
=======================================
  Hits         9149     9149           
  Misses        306      306           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles merged commit 7378e01 into master Oct 21, 2022
@Pierre-Gilles Pierre-Gilles deleted the fix-dashboard-list-refresh-bug branch October 21, 2022 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant