Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FR wording for slow delete of states in background #1632

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Oct 27, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Improve wording on delete of device with lots of states.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: af1b3b9
Status: ✅  Deploy successful!
Preview URL: https://1ca08f71.gladys-plus.pages.dev
Branch Preview URL: https://improve-wording-slow-delete-.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 96.76% // Head: 96.76% // No change to project coverage 👍

Coverage data is based on head (af1b3b9) compared to base (1785d5b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1632   +/-   ##
=======================================
  Coverage   96.76%   96.76%           
=======================================
  Files         650      650           
  Lines        9455     9455           
=======================================
  Hits         9149     9149           
  Misses        306      306           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Oct 27, 2022

Job #627: Bundle Size — 7.05MiB (~+0.01%).

f857758(current) vs 1785d5b master#612(baseline)

Metrics (2 changes)
                 Current
Job #627
     Baseline
Job #612
Initial JS 3MiB(~+0.01%) 3MiB
Initial CSS 294.57KiB 294.57KiB
Cache Invalidation 42.46% 0%
Chunks 50 50
Assets 145 145
Modules 1282 1282
Duplicate Modules 21 21
Duplicate Code 0.58% 0.58%
Packages 124 124
Duplicate Packages 10 10
Total size by type (1 change)
                 Current
Job #627
     Baseline
Job #612
CSS 312.54KiB 312.54KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.62MiB 1.62MiB
JS 5.02MiB (~+0.01%) 5.02MiB
Media 0B 0B
Other 4.59KiB 4.59KiB

View job #627 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit f857758 into master Oct 27, 2022
@Pierre-Gilles Pierre-Gilles deleted the improve-wording-slow-delete-device-states branch October 27, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant