Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gladys Plus: Prepare socket.io upgrade + bug-fix on login when instance is not up #1637

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Oct 31, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

Description of change

Prepare socket.io upgrade on Gladys Plus

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f9565f1
Status: ✅  Deploy successful!
Preview URL: https://bb74c62c.gladys-plus.pages.dev
Branch Preview URL: https://gladys-plus-fixes-socket.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 96.81% // Head: 96.81% // No change to project coverage 👍

Coverage data is based on head (f9565f1) compared to base (b016e59).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1637   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files         660      660           
  Lines        9628     9628           
=======================================
  Hits         9321     9321           
  Misses        307      307           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Oct 31, 2022

Job #654: Bundle Size — 7.05MiB (+0.02%).

825c4e2(current) vs b016e59 master#650(baseline)

Metrics (2 changes)
                 Current
Job #654
     Baseline
Job #650
Initial JS 3.11MiB(+0.05%) 3.11MiB
Initial CSS 294.87KiB 294.87KiB
Cache Invalidation 43.97% 0%
Chunks 52 52
Assets 148 148
Modules 1265 1265
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 124 124
Duplicate Packages 10 10
Total size by type (1 change)
                 Current
Job #654
     Baseline
Job #650
CSS 312.84KiB 312.84KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 5MiB (+0.03%) 5MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #654 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit 825c4e2 into master Oct 31, 2022
@Pierre-Gilles Pierre-Gilles deleted the gladys-plus-fixes-socket branch October 31, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant