Button click user friendly

[atrovato]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• [ ] If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Override button click values by user friendly wording.

See https://community.gladysassistant.com/t/affichage-des-boutons-textuels-dans-les-scenes-et-tableau-de-bord-au-lieu-dentier/7644

Dashboard

Scene

[codecov]

Codecov Report

Base: 97.54% // Head: 97.54% // No change to project coverage 👍

Coverage data is based on head (f1a5360) compared to base (0e1b0f8).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1642   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         649      649           
  Lines        9829     9829           
=======================================
  Hits         9588     9588           
  Misses        241      241           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[VonOx]

@Pierre-Gilles can you build front dev? I will test with gladys plus.

[Pierre-Gilles]

Great PR @atrovato ! Thanks 🙏

@VonOx Done ✅

You can find a build here: #1674 (comment)

Ping me anytime you want a new build, I will rebase my branch ;)

[VonOx]

@atrovato I can't save a scene with this trigger

UI is ok

[atrovato]

I had an error on update valie method in the "button click" trigger.
Now fixed @VonOx
And I rebase this branch with master.

[VonOx]

@atrovato state is not displayed after saving

If I use master codebase it is ( after saving with your PR )

[atrovato]

@VonOx Thank you.
I fixed it, and add this case in demo mode.

[Pierre-Gilles]

@VonOx Could you re-test on your side ? :)

[VonOx]

Yes @Pierre-Gilles I just need a test build on #1674

[Pierre-Gilles]

@VonOx Done in #1711. Build will be ready in a few minutes.

@atrovato Could you setup front builds on your own repository so it's automatic on your PR? :) It's not very fluid if I need to manually create a PR for every commit, we lose a lot of time 😅

[VonOx]

Everything is OK, can be merged

[Pierre-Gilles]

Thanks @VonOx ! Merged

[relativeci]

Job #1148: Bundle Size — 7.21MiB (+0.1%).

5f8632e(current) vs 50b2ed4 master#1096(baseline)

⚠️ Bundle contains 5 duplicate packages

Metrics (5 changes)

	Current Job #1148	Baseline Job #1096
Initial JS	4.22MiB(+0.12%)	4.22MiB
Initial CSS	300.25KiB	300.25KiB
Cache Invalidation	62.76%	0%
Chunks	51	51
Assets	149	149
Modules	1300(-2.91%)	1339
Duplicate Modules	20(+1900%)	1
Duplicate Code	0.81%(+8000%)	0.01%
Packages	116	116
Duplicate Packages	4	4

Total size by type (1 change)

	Current Job #1148	Baseline Job #1096
CSS	313.38KiB	313.38KiB
Fonts	93.55KiB	93.55KiB
HTML	13.58KiB	13.58KiB
IMG	1.66MiB	1.66MiB
JS	5.13MiB (+0.14%)	5.12MiB
Media	0B	0B
Other	15.74KiB	15.74KiB

---

View job #1148 report View master branch activity