-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
z2m thermostat mangement #1667
z2m thermostat mangement #1667
Conversation
Codecov ReportBase: 97.27% // Head: 97.27% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1667 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 643 643
Lines 9689 9689
=======================================
Hits 9425 9425
Misses 264 264
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b1de4b9
to
0400ecf
Compare
Nice!! Is this ready for review? If yes, can you provide a Docker build for testers? cc @LM1LC3N7 |
Is there a docker build yet @atrovato? |
Here the docker image https://community.gladysassistant.com/t/thermostat-avec-zigbee2mqtt/7634?u=alextrovato |
Sorry for the delay! @atrovato I tried the image and to use the thermostat through a fake mqtt device. Just to be clear, what do you want me to try? For now:
|
@LM1LC3N7 This PR is related to Zigbee devices, not MQTT devices. Have you tried in the Zigbee2mqtt integration? |
0400ecf
to
f0a94bf
Compare
I just rebased it, go for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine :)
f0a94bf
to
e9600db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's working fine for everyone, I'm good for a merge 🙂
Thanks for the PR @atrovato, great work 👏
Job #1012: Bundle Size — 7.01MiB (0%).
Metrics (no changes)
Total size by type (no changes)
|
https://community.gladysassistant.com/t/thermostat-avec-zigbee2mqtt/7634/5?u=alextrovato