Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z2m thermostat mangement #1667

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

atrovato
Copy link
Contributor

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 97.27% // Head: 97.27% // No change to project coverage 👍

Coverage data is based on head (e9600db) compared to base (1e02ce6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1667   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         643      643           
  Lines        9689     9689           
=======================================
  Hits         9425     9425           
  Misses        264      264           
Impacted Files Coverage Δ
server/services/zigbee2mqtt/exposes/numericType.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles
Copy link
Contributor

Nice!! Is this ready for review?

If yes, can you provide a Docker build for testers?

cc @LM1LC3N7

@LM1LC3N7
Copy link
Contributor

LM1LC3N7 commented Dec 12, 2022

Is there a docker build yet @atrovato?

@atrovato
Copy link
Contributor Author

Here the docker image atrovato/gladys:z2m-thermostat

https://community.gladysassistant.com/t/thermostat-avec-zigbee2mqtt/7634?u=alextrovato

@LM1LC3N7
Copy link
Contributor

LM1LC3N7 commented Jan 2, 2023

Sorry for the delay! @atrovato I tried the image and to use the thermostat through a fake mqtt device.

Just to be clear, what do you want me to try?

For now:

  1. Fake MQTT device created
  2. Added to one dashboard. ✅ I can update the value from here. ❌ But I am not sure it is retained. A refresh of the dashboard display again an empty box without value.
  3. From a scene, ✅ I can set a temperature using "control a device". ❌ But again, the value is empty by message or on the dashboard.

Screenshot_20230102-150743_Bromite

Screenshot_20230102-150650_Bromite
Screenshot_20230102-150703_Bromite
Screenshot_20230102-150724_Bromite
Screenshot_20230102-150631

@Pierre-Gilles
Copy link
Contributor

@LM1LC3N7 This PR is related to Zigbee devices, not MQTT devices. Have you tried in the Zigbee2mqtt integration?

@LM1LC3N7
Copy link
Contributor

LM1LC3N7 commented Jan 2, 2023

Oh! Thanks for the clarification 😅

Yep definitely my zigbee smart valve are detected and I can control them!

Screenshot_20230102-190732
Screenshot_20230102-190931_Firefox Nightly

@atrovato
Copy link
Contributor Author

atrovato commented Jan 3, 2023

I just rebased it, go for review :)

VonOx
VonOx previously approved these changes Jan 3, 2023
Copy link
Contributor

@VonOx VonOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine :)

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's working fine for everyone, I'm good for a merge 🙂

Thanks for the PR @atrovato, great work 👏

@Pierre-Gilles Pierre-Gilles merged commit 93e2a55 into GladysAssistant:master Jan 23, 2023
@relativeci
Copy link

relativeci bot commented Jan 23, 2023

Job #1012: Bundle Size — 7.01MiB (0%).

93e2a55(current) vs 1e02ce6 master#998(baseline)

Metrics (no changes)
                 Current
Job #1012
     Baseline
Job #998
Initial JS 3.03MiB 3.03MiB
Initial CSS 294.78KiB 294.78KiB
Cache Invalidation 0% 0%
Chunks 52 52
Assets 148 148
Modules 1258 1258
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 111 111
Duplicate Packages 8 8
Total size by type (no changes)
                 Current
Job #1012
     Baseline
Job #998
CSS 312.43KiB 312.43KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.95MiB 4.95MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #1012 reportView master branch activity

@atrovato atrovato deleted the z2m-thermostat branch March 25, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants