Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT: Fake "promise timeout" in MQTT tests to increase MQTT tests speed #1669

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

atrovato
Copy link
Contributor

Fake "promise timeout" in mqtt tests.

@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 97.25% // Head: 97.26% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3758144) compared to base (900b125).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1669   +/-   ##
=======================================
  Coverage   97.25%   97.26%           
=======================================
  Files         642      642           
  Lines        9671     9673    +2     
=======================================
+ Hits         9406     9408    +2     
  Misses        265      265           
Impacted Files Coverage Δ
server/services/mqtt/lib/installContainer.js 97.22% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles changed the title Atrovato/issue1660 MQTT: Fake "promise timeout" in MQTT tests to increase MQTT tests speed Jan 16, 2023
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!! It'll improve test speed, always good for the developer experience 😄

@Pierre-Gilles Pierre-Gilles merged commit 6d7d3e8 into GladysAssistant:master Jan 20, 2023
@relativeci
Copy link

relativeci bot commented Jan 20, 2023

Job #997: Bundle Size — 7.01MiB (0%).

6d7d3e8(current) vs 450cf1c master#996(baseline)

Metrics (1 change)
                 Current
Job #997
     Baseline
Job #996
Initial JS 3.03MiB 3.03MiB
Initial CSS 294.78KiB 294.78KiB
Cache Invalidation 0% 43.1%
Chunks 52 52
Assets 148 148
Modules 1258 1258
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 111 111
Duplicate Packages 8 8
Total size by type (no changes)
                 Current
Job #997
     Baseline
Job #996
CSS 312.43KiB 312.43KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.95MiB 4.95MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #997 reportView master branch activity

@atrovato atrovato deleted the atrovato/issue1660 branch March 18, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants