Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1679 : Weather box should refresh data every 30 minutes #1680

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Jan 2, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix refresh weather bug

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e613147
Status: ✅  Deploy successful!
Preview URL: https://78390695.gladys-plus.pages.dev
Branch Preview URL: https://fix-weather-refresh-update.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 97.26% // Head: 97.27% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e613147) compared to base (3df107c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1680      +/-   ##
==========================================
+ Coverage   97.26%   97.27%   +0.01%     
==========================================
  Files         643      643              
  Lines        9684     9684              
==========================================
+ Hits         9419     9420       +1     
+ Misses        265      264       -1     
Impacted Files Coverage Δ
server/lib/scene/scene.addScene.js 94.44% <0.00%> (+1.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Jan 2, 2023

Job #940: Bundle Size — 7MiB (~+0.01%).

ecccc20(current) vs 3df107c master#938(baseline)

Metrics (1 change)
                 Current
Job #940
     Baseline
Job #938
Initial JS 3.03MiB 3.03MiB
Initial CSS 294.78KiB 294.78KiB
Cache Invalidation 59.03% 63.03%
Chunks 52 52
Assets 148 148
Modules 1258 1258
Duplicate Modules 2 2
Duplicate Code 0.03% 0.03%
Packages 111 111
Duplicate Packages 8 8
Total size by type (1 change)
                 Current
Job #940
     Baseline
Job #938
CSS 312.43KiB 312.43KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.64MiB 1.64MiB
JS 4.95MiB (~+0.01%) 4.95MiB
Media 0B 0B
Other 4.95KiB 4.95KiB

View job #940 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit ecccc20 into master Jan 2, 2023
@Pierre-Gilles Pierre-Gilles deleted the fix-weather-refresh-update branch January 2, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant