Scenes - decimals in the "continue only if" block

[VonOx]

FIX #1585

[codecov]

Codecov Report

Base: 97.27% // Head: 97.27% // No change to project coverage 👍

Coverage data is based on head (071e7e4) compared to base (3d2ffc8).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1683   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files         643      643           
  Lines        9686     9686           
=======================================
  Hits         9422     9422           
  Misses        264      264           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[atrovato]

Some comments here 😉

[VonOx]

Some comments here 😉

Thank you Alex, I will make the change.

I have also changed the event to onBlur ( lost focus) because on change with actual if statement prevent decimal input (dot). With only parsefloat I can revert to onChange, I don't know what is the best.

[atrovato]

onBlur forces the user to leave the field for updates to be taken into account.
So if the user uses "enter" key on keyboard without leaving the field, changes on the filed will be avoid.
@VonOx

[VonOx]

@atrovato I've tested with "enter key" and focus is not lost and even if I hit save button on scene, new value is handled.
onBlur is working great here.

---

parseFloat(1.) = 1 => impossible to input decimal separator

onChange handle need to implement this kind of condition to prevent the behavior.

if (e.target.value.charAt(str.length - 1) === '.') {
  return;
}

But In that condition we need need an input validator because if user set 1. and nothing else , new value is not handled.

[atrovato]

Do I understand everything is alright?

[VonOx]

Do I understand everything is alright?

With onBlur => Yes

[atrovato]

Ok :)

[Pierre-Gilles]

EDIT: Deleting my previous message, it works!! Issue on my side :)

[Pierre-Gilles]

Good for me, it works fine in the UI and it works fine with a real device / real scene!

Thanks for this PR 🙏

PS: forget my previous review, I messed up my test ^^

[relativeci]

Job #995: Bundle Size — 7.01MiB (~-0.01%).

c553ec1(current) vs d5d81dd master#994(baseline)

Metrics (2 changes)

	Current Job #995	Baseline Job #994
Initial JS	3.03MiB(~-0.01%)	3.03MiB
Initial CSS	294.78KiB	294.78KiB
Cache Invalidation	43.1%	59.06%
Chunks	52	52
Assets	148	148
Modules	1258	1258
Duplicate Modules	2	2
Duplicate Code	0.03%	0.03%
Packages	111	111
Duplicate Packages	8	8

Total size by type (1 change)

	Current Job #995	Baseline Job #994
CSS	312.43KiB	312.43KiB
Fonts	93.55KiB	93.55KiB
HTML	13.58KiB	13.58KiB
IMG	1.64MiB	1.64MiB
JS	4.95MiB (~-0.01%)	4.95MiB
Media	0B	0B
Other	4.95KiB	4.95KiB

---

View job #995 report View master branch activity