-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MQTT container log limitation #1686
Add MQTT container log limitation #1686
Conversation
Sorry, I didn't have the time to test it in real life yet. |
Codecov ReportBase: 97.27% // Head: 97.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1686 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 643 643
Lines 9686 9687 +1
=======================================
+ Hits 9422 9423 +1
Misses 264 264
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
12eb888
to
e0683a7
Compare
I changed my choice, I use the existing service variable to know if docker file is at the latest revision. |
e0683a7
to
c4483a1
Compare
c4483a1
to
adfe9c0
Compare
Ok, I tested it, I can see this when I
Works fine according to me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my side, works fine! Thanks for this PR 🙏
Job #998: Bundle Size — 7.01MiB (0%).
Metrics (no changes)
Total size by type (no changes)
|
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add log limit on MQTT container.
I add a new service variable to track the container update.
Image :
atrovato/gladys:mqtt-log-limit