Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(front): Fix NaN dates display in Tasks list #1697

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

cicoub13
Copy link
Contributor

The idea is to transform created_at format to be in ISO8601 (compatible Firefox)

I took the text approach. To my opinion, better than using a Date library.
Seems not possible with Date object in Javascript 😞

Still working on Chrome/Safari ✅

https://community.gladysassistant.com/t/affichage-en-nan-des-dates-dans-longlet-taches-en-arriere-plan/7784/12?u=cicoub13

CleanShot 2023-01-23 at 15 38 36

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 97.27% // Head: 97.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d326011) compared to base (1e02ce6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1697   +/-   ##
=======================================
  Coverage   97.27%   97.28%           
=======================================
  Files         643      644    +1     
  Lines        9689     9712   +23     
=======================================
+ Hits         9425     9448   +23     
  Misses        264      264           
Impacted Files Coverage Δ
server/api/routes.js 98.03% <0.00%> (ø)
server/utils/httpErrors.js 100.00% <0.00%> (ø)
server/lib/gateway/index.js 100.00% <0.00%> (ø)
server/lib/gateway/gateway.openAIAsk.js 100.00% <0.00%> (ø)
server/api/controllers/gateway.controller.js 62.96% <0.00%> (+2.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cases are not covered by this PR (Websockets insert/update)

@cicoub13 cicoub13 force-pushed the front-fix-NaN-tasks branch from 91719fb to 66fb108 Compare January 26, 2023 15:14
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way better like this, thanks for this PR 🙏

@Pierre-Gilles Pierre-Gilles merged commit 8e353b3 into GladysAssistant:master Feb 6, 2023
@relativeci
Copy link

relativeci bot commented Feb 6, 2023

Job #1058: Bundle Size — 7.19MiB (~+0.01%).

8e353b3(current) vs 708b4ea master#1057(baseline)

Metrics (2 changes)
                 Current
Job #1058
     Baseline
Job #1057
Initial JS 4.21MiB(+0.01%) 4.21MiB
Initial CSS 300KiB 300KiB
Cache Invalidation 58.36% 0%
Chunks 51 51
Assets 149 149
Modules 1338 1338
Duplicate Modules 1 1
Duplicate Code 0.01% 0.01%
Packages 116 116
Duplicate Packages 4 4
Total size by type (1 change)
                 Current
Job #1058
     Baseline
Job #1057
CSS 313.13KiB 313.13KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.66MiB 1.66MiB
JS 5.11MiB (+0.01%) 5.11MiB
Media 0B 0B
Other 15.74KiB 15.74KiB

View job #1058 reportView master branch activity

euguuu pushed a commit to euguuu/Gladys that referenced this pull request Mar 5, 2023
@cicoub13 cicoub13 deleted the front-fix-NaN-tasks branch May 23, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants