-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(front): Fix NaN dates display in Tasks list #1697
fix(front): Fix NaN dates display in Tasks list #1697
Conversation
Codecov ReportBase: 97.27% // Head: 97.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1697 +/- ##
=======================================
Coverage 97.27% 97.28%
=======================================
Files 643 644 +1
Lines 9689 9712 +23
=======================================
+ Hits 9425 9448 +23
Misses 264 264
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some cases are not covered by this PR (Websockets insert/update)
91719fb
to
66fb108
Compare
66fb108
to
d326011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Way better like this, thanks for this PR 🙏
Job #1058: Bundle Size — 7.19MiB (~+0.01%).
Metrics (2 changes)
Total size by type (1 change)
|
The idea is to transform created_at format to be in ISO8601 (compatible Firefox)
I took the
text
approach. To my opinion, better than using a Date library.Seems not possible with Date object in Javascript 😞
Still working on Chrome/Safari ✅
https://community.gladysassistant.com/t/affichage-en-nan-des-dates-dans-longlet-taches-en-arriere-plan/7784/12?u=cicoub13