Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add air conditioning category #1718

Merged

Conversation

euguuu
Copy link
Contributor

@euguuu euguuu commented Mar 19, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add AC category

image

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (27eba3d) 97.56% compared to head (3656c6e) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1718   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         653      653           
  Lines        9932     9934    +2     
=======================================
+ Hits         9690     9692    +2     
  Misses        242      242           
Impacted Files Coverage Δ
server/utils/constants.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR! The code looks good to me, but I think there is piece of code missing to let the front display the "AC Mode" type.

I can't get to display the mode:

Screenshot 2023-03-24 at 13 10 38

To reproduce this, create a "AC" type in the MQTT integration :)

@euguuu
Copy link
Contributor Author

euguuu commented Mar 26, 2023

Very nice PR! The code looks good to me, but I think there is piece of code missing to let the front display the "AC Mode" type.

I can't get to display the mode:

Screenshot 2023-03-24 at 13 10 38

To reproduce this, create a "AC" type in the MQTT integration :)

I fix this issue

@euguuu euguuu requested a review from Pierre-Gilles March 26, 2023 15:11
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my side now!

Screenshot 2023-03-31 at 14 10 19

Thanks for this development 🙏

@Pierre-Gilles Pierre-Gilles merged commit 772a96d into GladysAssistant:master Mar 31, 2023
@relativeci
Copy link

relativeci bot commented Mar 31, 2023

Job #1201: Bundle Size — 7.21MiB (+0.09%).

772a96d(current) vs 27eba3d master#1183(baseline)

⚠️ Bundle contains 5 duplicate packages

Metrics (3 changes)
                 Current
Job #1201
     Baseline
Job #1183
Initial JS 4.22MiB(+0.04%) 4.22MiB
Initial CSS 300.25KiB 300.25KiB
Cache Invalidation 62.79% 58.69%
Chunks 51 51
Assets 149 149
Modules 1302(+0.08%) 1301
Duplicate Modules 20 20
Duplicate Code 0.81% 0.81%
Packages 116 116
Duplicate Packages 4 4
Total size by type (1 change)
                 Current
Job #1201
     Baseline
Job #1183
CSS 313.38KiB 313.38KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.66MiB 1.66MiB
JS 5.13MiB (+0.13%) 5.12MiB
Media 0B 0B
Other 15.74KiB 15.74KiB

View job #1201 reportView master branch activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants