Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean eslint default parameter order warning #1720

Merged

Conversation

atrovato
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • ~~[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Clean warnings on build time.

/home/alex/Gladys/server/services/zigbee2mqtt/utils/features/buildFeatures.js
  13:28  warning  Default parameters should be last  default-param-last
  27:22  warning  Default parameters should be last  default-param-last
  47:36  warning  Default parameters should be last  default-param-last

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f1f4887) 97.55% compared to head (00f1d06) 97.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1720   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         652      652           
  Lines        9909     9909           
=======================================
  Hits         9667     9667           
  Misses        242      242           
Impacted Files Coverage Δ
...rvices/zigbee2mqtt/utils/features/buildFeatures.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Pierre-Gilles Pierre-Gilles merged commit 58a02f0 into GladysAssistant:master Mar 24, 2023
@relativeci
Copy link

relativeci bot commented Mar 24, 2023

Job #1161: Bundle Size — 7.21MiB (0%).

58a02f0(current) vs 5d2a61e master#1160(baseline)

⚠️ Bundle contains 5 duplicate packages

Metrics (no changes)
                 Current
Job #1161
     Baseline
Job #1160
Initial JS 4.22MiB 4.22MiB
Initial CSS 300.25KiB 300.25KiB
Cache Invalidation 0% 0%
Chunks 51 51
Assets 149 149
Modules 1300 1300
Duplicate Modules 20 20
Duplicate Code 0.81% 0.81%
Packages 116 116
Duplicate Packages 4 4
Total size by type (no changes)
                 Current
Job #1161
     Baseline
Job #1160
CSS 313.38KiB 313.38KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.66MiB 1.66MiB
JS 5.13MiB 5.13MiB
Media 0B 0B
Other 15.74KiB 15.74KiB

View job #1161 reportView master branch activity

@atrovato atrovato deleted the eslint-default-param-z2m branch March 25, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants