Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gladys Plus: Display error message when local user is not accepted #1728

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.

Description of change

Fix #1699

Screenshot 2023-03-31 at 15 05 14

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 72c75ff
Status: ✅  Deploy successful!
Preview URL: https://df2530ec.gladys-plus.pages.dev
Branch Preview URL: https://fix-gladys-plus-remote-acces.gladys-plus.pages.dev

View logs

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (de1ff0e) 97.56% compared to head (72c75ff) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1728   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         653      653           
  Lines        9948     9948           
=======================================
  Hits         9706     9706           
  Misses        242      242           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@relativeci
Copy link

relativeci bot commented Mar 31, 2023

Job #1205: Bundle Size — 7.21MiB (~-0.01%).

ec9182e(current) vs de1ff0e master#1203(baseline)

⚠️ Bundle contains 5 duplicate packages

Metrics (1 change)
                 Current
Job #1205
     Baseline
Job #1203
Initial JS 4.22MiB 4.22MiB
Initial CSS 300.25KiB 300.25KiB
Cache Invalidation 58.49% 0%
Chunks 51 51
Assets 149 149
Modules 1302 1302
Duplicate Modules 20 20
Duplicate Code 0.81% 0.81%
Packages 116 116
Duplicate Packages 4 4
Total size by type (1 change)
                 Current
Job #1205
     Baseline
Job #1203
CSS 313.38KiB 313.38KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.66MiB 1.66MiB
JS 5.13MiB (~-0.01%) 5.13MiB
Media 0B 0B
Other 15.74KiB 15.74KiB

View job #1205 reportView master branch activity

@Pierre-Gilles Pierre-Gilles merged commit ec9182e into master Mar 31, 2023
@Pierre-Gilles Pierre-Gilles deleted the fix-gladys-plus-remote-access-error branch March 31, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gladys Plus User Link error without message
1 participant