Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zigbee2mqtt): Filter unknown models #1997

Merged

Conversation

cicoub13
Copy link
Contributor

@cicoub13 cicoub13 commented Jan 4, 2024

New devices are in the discoverd devices list (like dongle) without model (due to release https://github.com/Koenkk/zigbee2mqtt/releases/tag/1.35.0)

We need to filter them before converting them to Gladys devices.

New devices are in the discoverd devices list (like dongle) without model (due to release https://github.com/Koenkk/zigbee2mqtt/releases/tag/1.35.0)
We need to filter them before converting them to Gladys devices.
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fa0bed) 98.19% compared to head (aa697d7) 98.20%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
+ Coverage   98.19%   98.20%   +0.01%     
==========================================
  Files         786      786              
  Lines       12307    12382      +75     
==========================================
+ Hits        12085    12160      +75     
  Misses        222      222              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Jan 4, 2024

Job #2240: Bundle Size — 9.38MiB (0%).

aa697d7(current) vs 396efc7 master#2235(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2240
     Baseline
Job #2235
No change  Initial JS 5.18MiB 5.18MiB
No change  Initial CSS 302.44KiB 302.44KiB
Change  Cache Invalidation 0% 53.88%
No change  Chunks 51 51
No change  Assets 158 158
No change  Modules 1425 1425
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.81% 0.81%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
Job #2240
     Baseline
Job #2235
Not changed  JS 6.87MiB 6.87MiB
Not changed  IMG 2.08MiB 2.08MiB
Not changed  CSS 318.94KiB 318.94KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 16.14KiB 16.14KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #2240 reportView cicoub13:fix-zigbee-discovered-d... branch activity

@cicoub13 cicoub13 closed this Jan 4, 2024
@Pierre-Gilles Pierre-Gilles reopened this Jan 8, 2024
@Pierre-Gilles Pierre-Gilles merged commit a967df5 into GladysAssistant:master Jan 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants