Function is it right time #349
Conversation
Test si c'est la bonne heure
ajout de la fonction isItRightTime
|
Hey! Is it ready for merge ? :) What's your use case on this ? |
|
Hi, I currently use it under scenario conditions to set a validation time range. I would then make a PR in the data to add the condition if this is ok for you. |
|
Use |
|
is good, thanks |
api/core/time/time.isItRightTime.js
Outdated
| // settings default options if not defined | ||
| options = options || {}; | ||
| options.start = date; | ||
| options.end = endDate; |
There was a problem hiding this comment.
Are these 3 lines useful ? I don't think so!
There was a problem hiding this comment.
ah yes well seen, I forget to remove them, initially I wanted to return data after I change a true / false
There was a problem hiding this comment.
Ok! Waiting for your review before merging :)
api/core/time/time.isItRightTime.js
Outdated
| var arrayOfEnd = options.end.split(":"); | ||
|
|
||
| // default start time 00:00:00 | ||
| var date = new Date(); |
There was a problem hiding this comment.
Consider renaming the variable to "startDate", more explicit
There was a problem hiding this comment.
it's not my part that I prefer to give explicit names to variables lol
but you already noticed
|
and in the stride I can add in the base the condition for the scenarios !! |
changing the variable name to startDate and removing unnecessary functions
|
It's now merged! :) I just renamed the function "isInTimeRange" because your old function name was clearly not explicit. Thanks for your work! |
function isItRightTime.
Valide if the time is in the range definided.
For the addition in the conditions of the scenarios.