Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐳 Switch from node:carbon to node:8-alpine for Docker base image and add Timezone feature #376

Merged
merged 3 commits into from
Jul 13, 2018

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Jul 11, 2018

Build and Run test with success

Purpose of this modification is to reduce images size

  • Size with node:carbon = 979.9 MB
  • Size with node:alpine = 375.4 MB

@VonOx
Copy link
Contributor Author

VonOx commented Jul 11, 2018

165 MB on docker hub ( was 408MB )

@VonOx VonOx changed the title Switch from node:carbon to node:8-alpine for Docker base image 🐳 Switch from node:carbon to node:8-alpine for Docker base image Jul 11, 2018
@VonOx VonOx changed the title 🐳 Switch from node:carbon to node:8-alpine for Docker base image 🐳 Switch from node:carbon to node:8-alpine for Docker base image Jul 11, 2018
@VonOx VonOx changed the title 🐳 Switch from node:carbon to node:8-alpine for Docker base image 🐳 Switch from node:carbon to node:8-alpine for Docker base image and add Timezone feature Jul 12, 2018
@Pierre-Gilles Pierre-Gilles merged commit 42af401 into GladysAssistant:master Jul 13, 2018
@Pierre-Gilles
Copy link
Contributor

Nice! Thanks for your PR :)

R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
🐳 Switch from node:carbon to node:8-alpine for Docker base image and add Timezone feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants