Correction of the slider width to no longer display the horizontal scroll + doc for deviceType.getByCategory #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rolls If you set `slider-horizontal-width` to `100%`; the slider-tick-label goes beyond the container at max value : **before:**  **After:** 
piznel
changed the title
|
Hey! Thanks for the PR! I'm trying to reproduce your bug but i can't manage to reproduce it... When exactly does it happens? Is there with a specific screen resolution? :) |
|
I have it with Windows 7, on Chrome and Firefox (latest version), at the resolution recommended by my screen. |
|
Got it! I see what you mean and i'm able to reproduce indeed! I'm merging right now |
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
…roll + doc for deviceType.getByCategory (GladysAssistant#414) * Correction of the slider width to no longer display the horizontal scrolls If you set `slider-horizontal-width` to `100%`; the slider-tick-label goes beyond the container at max value : **before:**  **After:**  * Add deviceType.getByCategory doc * Add 'gladys.deviceType.getByCategory' to jsdoc.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you set
slider-horizontal-widthto100%; the slider-tick-label goes beyond the container at max value :before:
After: