Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test Node.js 11 #451

Merged
merged 1 commit into from
Nov 26, 2018
Merged

ci: test Node.js 11 #451

merged 1 commit into from
Nov 26, 2018

Conversation

DanielRuf
Copy link
Contributor

Gladys Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing?
  • Is the linter (eslint) passing?
  • If your changes modify the API (REST or Node.js), did you modify the documentation?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

This PR adds node to the test matrix so we test also against the current stable Node.js version (which is currently 11) to ensure that Gladys also works there.

@Pierre-Gilles Pierre-Gilles merged commit 702c1f6 into GladysAssistant:master Nov 26, 2018
@Pierre-Gilles
Copy link
Contributor

Thanks for your PR, good idea :)

@DanielRuf DanielRuf deleted the ci/test-nodejs-11 branch November 26, 2018 06:14
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants