Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues #462 #463

Merged
merged 3 commits into from
Jan 28, 2019
Merged

issues #462 #463

merged 3 commits into from
Jan 28, 2019

Conversation

piznel
Copy link
Contributor

@piznel piznel commented Dec 10, 2018

Gladys Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [N/A] If your changes affects code, did your write the tests?
  • [N/A] Are tests passing?
  • Is the linter (eslint) passing?
  • [N/A] If your changes modify the API (REST or Node.js), did you modify the documentation?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix issue #462 and the following bugs :

  • if the devicetype had no name,'undefined' was displayed
  • the navigation buttons did not work properly if we were in real-time data display.
  • the addition of a real time value drew a straight line between the first point of the graph and the last point.
  • adding a real time value added it to the graph even if we displayed a curve in the past.

@Pierre-Gilles Pierre-Gilles merged commit 7ff8d29 into GladysAssistant:master Jan 28, 2019
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants