🐳 Docker multiarch support #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nmap is necessary for some module
* FIX typo in Dockerfile.arm32v7 * FIX missing `&&` in layer * Build script creation for multiarch images ( with manifest ) * Removed useless comment in Dockerfiles and improve readability
|
Travis build fail, @Pierre-Gilles are you using email adress as username for docker login ? https://travis-ci.org/GladysProject/Gladys/jobs/467539858#L575 |
|
@VonOx I don't think so, in Travis I have 2 variables: DOCKER_USERNAME and DOCKER_PASSWORD. I can't read the value, but I'm pretty sure it's my username and not the email. I restarted the build to be sure :) |
|
Ok failed... trying again and changing the username to be sure |
|
Oh i understand! Travis env variables are not available for pull requests! :p Otherwise you would be able to get my password by console.log my passwords ^^ |
|
Yeah that explain why build fail. Work on my side 😉 |
|
Great! Amazing work btw! :) I just merged, should work on master. It's gonna help a lot for the work on Gladys 4! |
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
* Update Dockerfile Nmap is necessary for some module * * Switch to LTS base image * FIX typo in Dockerfile.arm32v7 * FIX missing `&&` in layer * Build script creation for multiarch images ( with manifest ) * Removed useless comment in Dockerfiles and improve readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
&&in layerWarning
Travis build is ok
Intel image works fine, but arm base image need to be tested in proper hardware before merging.