-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth service #505
Bluetooth service #505
Conversation
c1a807f
to
f5086f8
Compare
server/services/bluetooth/lib/commands/bluetooth.determinePeripheral.js
Outdated
Show resolved
Hide resolved
Wait #512 PR to be merged to get device / feature definition updates. |
fba2cf9
to
3c4f839
Compare
Hello! De retour de congés, je reprend les PR une par une. A quel niveau es-tu sur celle-ci? |
Salut, suite à notre discussion sur MQTT et les sub-services, ce service nécessite de grandes modifications. Du coup, la relecture n'est pas encore nécessaire. |
The service is still in standby, the community is moving on noble library, and some others may appear soon. |
Ok! |
3c4f839
to
b21826a
Compare
110925b
to
7666874
Compare
7666874
to
58e0feb
Compare
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 93.50% 93.53% +0.02%
==========================================
Files 428 461 +33
Lines 5607 6112 +505
==========================================
+ Hits 5243 5717 +474
- Misses 364 395 +31
Continue to review full report at Codecov.
|
Back on Bluetooth ? 😍 |
Just tried with last @abandonware/noble, but not working on windows... |
2f2a8fd
to
37b049f
Compare
cf96978
to
bf21d21
Compare
235b4c5
to
526b491
Compare
5752ec1
to
bac7f10
Compare
Thank you very much for this PR, this is gold 🥇 I just put one small comment. Do you think it could be merged in master? I tested it on my side, it works fine on the UI/discovery part. I don't have much devices to tests so I'm not the best user to test this, but if it's stable we can definitely merge it on master so all users can try it before the RC :) |
8bd7357
to
cd036e6
Compare
Hey! Thanks for your changes. Is this ready to merge? |
🥳 |
Many thanks for your work on this major PR @atrovato ! 🥳 This was the n°1 requests for Gladys 4, and we now have it :) Can't wait to see more integrations around the bluetooth in Gladys. |
* Bluetooth service * Bluetooth: improve front * Bluetooth: fix random test conflicted with caldav * Bluetooth: fix docker script * Rollback circle changes
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Bluetooth service to handle Bluetooth devices.