Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xiaomi Service #537

Merged
merged 36 commits into from
Oct 4, 2019
Merged

Xiaomi Service #537

merged 36 commits into from
Oct 4, 2019

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 23, 2019

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the documentation? (Documentation is based on comments in code)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@89a87d8). Click here to learn what that means.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #537   +/-   ##
=========================================
  Coverage          ?   91.71%           
=========================================
  Files             ?      374           
  Lines             ?     4444           
  Branches          ?        0           
=========================================
  Hits              ?     4076           
  Misses            ?      368           
  Partials          ?        0
Flag Coverage Δ
#server 91.71% <95.23%> (?)
Impacted Files Coverage Δ
server/models/device.js 100% <ø> (ø)
server/utils/constants.js 100% <ø> (ø)
...es/xiaomi/lib/event/xiaomi.newValueMotionSensor.js 100% <100%> (ø)
...r/services/xiaomi/lib/event/xiaomi.newValueLeak.js 100% <100%> (ø)
...rver/services/xiaomi/lib/event/xiaomi.listening.js 100% <100%> (ø)
...i/lib/event/xiaomi.newValueDuplexWirelessSwitch.js 100% <100%> (ø)
...rver/services/xiaomi/lib/event/xiaomi.addDevice.js 100% <100%> (ø)
...ervices/xiaomi/lib/event/xiaomi.newValueGateway.js 100% <100%> (ø)
server/services/xiaomi/api/xiaomi.controller.js 100% <100%> (ø)
server/services/xiaomi/lib/index.js 100% <100%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a87d8...4d2b486. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 47da69e into master Oct 4, 2019
@Pierre-Gilles Pierre-Gilles deleted the xiaomi-service branch October 4, 2019 16:14
@Pierre-Gilles Pierre-Gilles mentioned this pull request Oct 4, 2019
5 tasks
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
* First commit

* Centralize deviceStatus in constant file

* Add cube sensor

* Handle Xiaomi switch

* Handle Xiaomi leak sensor

* Improve server with new websockets event

* Remove unique index when it's not needed

* Add more advanced search in device.get query

* Specify add_feedback attribute in Xiaomi sensors

* First version of frontend

* Add function to convert HSL colors to RGB

* Add util function to get device param / set device param

* Handle gateway + setValue gateway to control colors

* Add smoke & vibration sensor

* Handle xiaomi plugs

* Handle single wired switch

* Handle duplex wired switch

* Handle single wired switch neutral

* Handle duplex wired switch neutral

* Handle duplex wireless switch

* Handle single wireless switch

* Handle illumination in gateway

* Control duplex switch, first poc

* Front: add more consts for devices

* Add Xiaomi edit page

* Better error handling + added tests

* Add more tests

* Add tests to unit converter

* Remove battery attribute from plug device

* Add more tests to xiaomi service

* Improve coverage

* Add link to documentation in Xiaomi page

* Add coverage folder to gitignore

* Improve coverage on controller + type of devices

* Add data in demo mode for Xiaomi

* Switch VERSION to alpha-2 for Docker build version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant