Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle new Philips Hue models #564

Merged
merged 6 commits into from
Oct 21, 2019
Merged

Handle new Philips Hue models #564

merged 6 commits into from
Oct 21, 2019

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Oct 21, 2019

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #564 into master will increase coverage by 0.04%.
The diff coverage is 94.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   91.67%   91.72%   +0.04%     
==========================================
  Files         376      381       +5     
  Lines        4625     4675      +50     
==========================================
+ Hits         4240     4288      +48     
- Misses        385      387       +2
Flag Coverage Δ
#server 91.72% <94.91%> (+0.04%) ⬆️
Impacted Files Coverage Δ
server/utils/constants.js 100% <ø> (ø) ⬆️
...erver/services/philips-hue/lib/light/light.init.js 89.47% <100%> (ø) ⬆️
server/services/philips-hue/api/hue.controller.js 100% <100%> (ø) ⬆️
server/services/philips-hue/lib/models/white.js 100% <100%> (ø)
...ces/philips-hue/lib/models/colorWithTemperature.js 100% <100%> (ø)
...ces/philips-hue/lib/models/whiteWithTemperature.js 100% <100%> (ø)
server/services/philips-hue/lib/light/index.js 100% <100%> (ø) ⬆️
.../services/philips-hue/lib/light/light.getLights.js 96.55% <100%> (+1.55%) ⬆️
...ces/philips-hue/lib/light/light.configureBridge.js 86.95% <66.66%> (ø) ⬆️
...vices/philips-hue/lib/light/light.activateScene.js 83.33% <83.33%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99384f1...8d6a540. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit fcba3d2 into master Oct 21, 2019
@Pierre-Gilles Pierre-Gilles deleted the philips-hue-new-models branch October 21, 2019 16:49
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
* Handle new philips hue models

* Fix linting

* Add tests to scenes API philips hue

* Add tests to philips hue controller

* Tests all lamps philips hue

* Handle all types of lights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant