Fix zWave port listing and binding #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 91.89% 91.91% +0.01%
==========================================
Files 396 396
Lines 4824 4821 -3
==========================================
- Hits 4433 4431 -2
+ Misses 391 390 -1
Continue to review full report at Codecov.
|
|
Many thanks for this PR, this was indeed the bug! |
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
* Fix zWave port listing and binding * Prettier * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
The request to list available ports to select the zWave USB stick remains unfinished.
This is because of a BC in SerialPort: the list method is now returning a Promise and doesn't support the callback parameter. See here: https://github.com/serialport/node-serialport/blob/master/UPGRADE_GUIDE.md#upgrading-from-7x-to-8x
In the BC, the
comNamefield is now namedpath.By the way, this PR also fix an issue when selecting a value in the selector and clicking "Connect": the value sent to the server was an empty string.