Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-Wave Improvements #615

Merged
merged 10 commits into from
Dec 3, 2019
Merged

Z-Wave Improvements #615

merged 10 commits into from
Dec 3, 2019

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Nov 20, 2019

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #615 into master will increase coverage by 0.05%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   91.83%   91.89%   +0.05%     
==========================================
  Files         400      404       +4     
  Lines        4876     4936      +60     
==========================================
+ Hits         4478     4536      +58     
- Misses        398      400       +2
Flag Coverage Δ
#server 91.89% <90%> (+0.05%) ⬆️
Impacted Files Coverage Δ
server/utils/constants.js 100% <ø> (ø) ⬆️
server/lib/device/device.newStateEvent.js 77.77% <0%> (+7.77%) ⬆️
...erver/services/zwave/lib/events/zwave.nodeAdded.js 100% <100%> (ø) ⬆️
...ver/services/zwave/lib/events/zwave.nodeRemoved.js 100% <100%> (ø)
...rver/services/zwave/lib/commands/zwave.getNodes.js 96% <100%> (+12.66%) ⬆️
server/services/zwave/lib/index.js 100% <100%> (ø) ⬆️
server/services/zwave/lib/utils/getUnit.js 62.5% <62.5%> (ø)
server/services/zwave/lib/constants.js 100% <0%> (ø)
server/services/zwave/lib/utils/getCategory.js 100% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32115ef...e3280f6. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit da9fc1e into master Dec 3, 2019
@Pierre-Gilles Pierre-Gilles deleted the zwave-improvements branch December 3, 2019 13:48
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
* Remove useless error message in device.newStateEvent

* handle zwave "node removed" message

* Improve node inclusion/exclusion process

* Add edit device page

* Zwave format device server-side

* Improve unit and display of devices

* Add mocked node data to zwave tests

* Switch newStateEvent to debug

* Fix demo mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant