-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Script to test single service #622
Conversation
Nice! Could it be possible to have a parameters instead of a env variable? Like :
? |
I searched for, but didn't find anything for npm scripts using command args. |
I can't find any other simple solution. |
039bf15
to
e527e78
Compare
I think it's possible:
|
I may mis something, but I can't make it work. |
Updated to |
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 428 428
Lines 5578 5578
=======================================
Hits 5215 5215
Misses 363 363 Continue to review full report at Codecov.
|
Merci pour cette PR ! :) Je regarde la semaine prochaine lors de mes jours Gladys. |
Thanks for your PR ! I updated the doc with the script: |
Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
If your changes affects code, did your write the tests?Are tests passing? (npm test
on both front/server)Is the linter passing? (npm run eslint
on both front/server)Did you run prettier? (npm run prettier
on both front/server)If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.Did you add fake requests data for the demo mode (front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add script to test single service.
Usage
SERVICE=zwave npm run test-service