Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Gladys Plus fixes (Fixes #660) #695

Merged
merged 4 commits into from
Mar 14, 2020
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Mar 14, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #695 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #695   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         393      393           
  Lines        4962     4962           
=======================================
  Hits         4559     4559           
  Misses        403      403
Flag Coverage Δ
#server 91.87% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebadd61...634d80e. Read the comment docs.

@Pierre-Gilles Pierre-Gilles changed the title Fix redirect on Gladys Plus when refresh token is no longer valid Multiple Gladys Plus fixes Mar 14, 2020
@Pierre-Gilles Pierre-Gilles changed the title Multiple Gladys Plus fixes Multiple Gladys Plus fixes (Fixes #660) Mar 14, 2020
@Pierre-Gilles Pierre-Gilles merged commit ca9d7da into master Mar 14, 2020
@Pierre-Gilles Pierre-Gilles deleted the gladys-plus-fixes branch March 14, 2020 15:34
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…nt#695)

* Fix redirect on Gladys Plus when refresh token is no longer valid

* Add apple-touch-icon

* Fix user firstname not displayed at first login

* Fix responsive on dashboard & chat page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant