-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data event parsing & add host #754
Fix data event parsing & add host #754
Conversation
Codecov Report
@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 92.71% 92.78% +0.06%
==========================================
Files 419 419
Lines 5421 5416 -5
==========================================
- Hits 5026 5025 -1
+ Misses 395 391 -4
Continue to review full report at Codecov.
|
Hey! Thanks for the fixes 🙂 It seems that your code coverage is a little bit low, do you see how to fix it? |
44f3d06
to
8f00e1e
Compare
I'm back, and try to fix that. |
GladysAssistant#754) * Fix data event parsing & add host * Improve code coverage * Improve code coverage Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
GladysAssistant#754) * Fix data event parsing & add host * Improve code coverage * Improve code coverage Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
This PR:
Content-Type
header withapplication/xml
as value (mandatory for some hosts).