-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #779 fixed bottom dashboard edition bar #783
Fix #779 fixed bottom dashboard edition bar #783
Conversation
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 419 419
Lines 5427 5427
=======================================
Hits 5014 5014
Misses 413 413 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b1adc1c
to
cc803ec
Compare
Should be fixed now :) |
Thanks !! 🙏 |
GladysAssistant#783) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
GladysAssistant#783) Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[ ] If your changes affects code, did your write the tests?npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.[ ] Did you add fake requests data for the demo mode (front/src/config/demo.json
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Proposal for #779
Keep Save/Cancel buttons accessible on dashboard edition.