Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #779 fixed bottom dashboard edition bar #783

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented May 9, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Proposal for #779
Keep Save/Cancel buttons accessible on dashboard edition.

dashboard-fixed-edit-bar

@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #783 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #783   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files         419      419           
  Lines        5427     5427           
=======================================
  Hits         5014     5014           
  Misses        413      413           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7be18f8...0829a4d. Read the comment docs.

@atrovato atrovato requested a review from Pierre-Gilles May 16, 2020 13:54
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It's really better indeed.

Just one issue, on mobile, the button is a little too much on the right:

Screenshot 2020-05-18 at 12 00 55

@atrovato atrovato force-pushed the fix-#779-dashboard-edit-save-button branch from b1adc1c to cc803ec Compare May 21, 2020 07:08
@atrovato
Copy link
Contributor Author

Should be fixed now :)

@Pierre-Gilles
Copy link
Contributor

Thanks !! 🙏

@Pierre-Gilles Pierre-Gilles merged commit 90f7957 into GladysAssistant:master May 25, 2020
NickDub-old pushed a commit to NickDub/Gladys that referenced this pull request Aug 7, 2020
GladysAssistant#783)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
GladysAssistant#783)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@atrovato atrovato deleted the fix-#779-dashboard-edit-save-button branch November 28, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants