Docker build on PR via GitHub actions

[VonOx]

This resolve #626 by providing docker build on PR by using Github Actions

After successful build, PR is commented with docker command to test the image

You need to set Github Secrets in the repo for pushing image to dockerhub:

• DOCKER_PASSWORD
• DOCKER_USER

Configured for dockerhub repo named gladys-dev

[Pierre-Gilles]

Wow! Really nice! 👏

[VonOx]

I've made modification related to OZW build.
This can now be merged

[Pierre-Gilles]

Thanks for this great PR ! First PR building here:

https://github.com/GladysAssistant/Gladys/pull/808/checks?check_run_id=685353843

[Pierre-Gilles]

Mmm seems the login failed

yes, I did put the secrets:

Did this work on your repo?

[VonOx]

Yeah its working fine on my repo https://github.com/VonOx/Gladys4_GithubActions

EDIT: I think secrets must be at repo level not organization.
Or maybe access policy behavior ?
https://github.blog/changelog/2020-05-14-organization-secrets/

[Pierre-Gilles]

It's supposed to be ok, I put only the Gladys repo:

I started another PR to see if it works =>

https://github.com/GladysAssistant/Gladys/pull/783/checks?check_run_id=685812996

[Pierre-Gilles]

One question: how is it different from CircleCI? Are secret shared with third-party pull request?

How is it safer that what we couldn't do with CircleCI?

[Pierre-Gilles]

From what I found, it seems it's not possible to use secrets in Github Actions from PR =>

https://gh.neting.ccmunity/t5/GitHub-Actions/Make-secrets-available-to-builds-of-forks/td-p/30678

So this doesn't work

[Pierre-Gilles]

Sadly it's broken on your repo as well :/

https://github.com/VonOx/Gladys4_GithubActions/pull/16

[Pierre-Gilles]

[VonOx]

F**k! I've made several PR to test, but forking his own repo is not possible.

[VonOx]

Back to square one !

Github Actions and CircleCI have the same behavior on Fork . The risk is important for any CI system.

I've no solution for now 😞

[Pierre-Gilles]

ok ! I'll remove the Github actions on master then