Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #713 session device #799

Merged

Conversation

atrovato
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Display device information linked to session.

image

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #799 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   92.40%   92.40%           
=======================================
  Files         419      419           
  Lines        5426     5426           
=======================================
  Hits         5014     5014           
  Misses        412      412           
Flag Coverage Δ
#server 92.40% <100.00%> (ø)
Impacted Files Coverage Δ
server/lib/session/session.create.js 100.00% <ø> (ø)
server/models/session.js 100.00% <ø> (ø)
server/api/controllers/user.controller.js 100.00% <100.00%> (ø)
server/lib/session/session.get.js 100.00% <100.00%> (ø)
server/lib/user/user.forgotPassword.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021b415...65dfd3b. Read the comment docs.

@atrovato atrovato requested a review from Pierre-Gilles May 16, 2020 13:54
@Pierre-Gilles Pierre-Gilles merged commit 2e9c66d into GladysAssistant:master May 18, 2020
NickDub-old pushed a commit to NickDub/Gladys that referenced this pull request Aug 7, 2020
…ant#799)

Fix GladysAssistant#713

* Store useragent from req to DB
* Session device useragant display

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…ant#799)

Fix GladysAssistant#713

* Store useragent from req to DB
* Session device useragant display

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@atrovato atrovato deleted the fix-#713-session-device branch November 28, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants