Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependency 'vis' #808

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

atrovato
Copy link
Contributor

Fixes #807

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ ] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Upgrade vis library.

@atrovato atrovato force-pushed the atrovato/issue807 branch from a4c0bb5 to 7f94f54 Compare May 21, 2020 07:11
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #808 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #808   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         428      428           
  Lines        5578     5578           
=======================================
  Hits         5215     5215           
  Misses        363      363           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388455a...e7e4e85. Read the comment docs.

@atrovato
Copy link
Contributor Author

Warning message at startup desapears

[BABEL] Note: The code generator has deoptimised the styling of "/home/alex/Gladys/front/node_modules/vis/dist/vis.js" as it exceeds the max of "500KB".

@Pierre-Gilles
Copy link
Contributor

Merci pour cette PR ! :) Je regarde la semaine prochaine lors de mes jours Gladys.

@Pierre-Gilles Pierre-Gilles merged commit 8dc3a24 into GladysAssistant:master Aug 24, 2020
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
@atrovato atrovato deleted the atrovato/issue807 branch November 28, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated dependency 'vis'
2 participants