Dashboard MQTT display the feature name Fixes #787 #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #852 +/- ##
=======================================
Coverage 93.49% 93.49%
=======================================
Files 428 428
Lines 5578 5579 +1
=======================================
+ Hits 5215 5216 +1
Misses 363 363
Continue to review full report at Codecov.
|
…ature name of a binary device, not the device name Fixes GladysAssistant#787
atrovato
force-pushed
the
atrovato/issue787
branch
from
1efe2fe to
0025254
Compare
R6n0
pushed a commit
to R6n0/Gladys
that referenced
this pull request
Dec 2, 2020
…ature name of a binary device, not the device name (GladysAssistant#852) Fixes GladysAssistant#787 Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm teston both front/server)npm run eslinton both front/server)npm run prettieron both front/server)[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translationson front)[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Force feature name usage (instead of device name) for MQTT device, on "devices in the room" box on dashboard.