Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #727 : The user should be able to set the timezone used in scenes in the UI #856

Merged
merged 6 commits into from
Aug 25, 2020

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #856 into master will increase coverage by 0.00%.
The diff coverage is 95.83%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #856   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files         428      428           
  Lines        5578     5595   +17     
=======================================
+ Hits         5215     5231   +16     
- Misses        363      364    +1     
Impacted Files Coverage Δ
.../services/philips-hue/lib/light/light.getLights.js 97.14% <ø> (ø)
server/utils/constants.js 100.00% <ø> (ø)
server/lib/variable/variable.setValue.js 90.00% <83.33%> (-10.00%) ⬇️
server/lib/index.js 94.28% <100.00%> (ø)
server/lib/room/room.getBySelector.js 100.00% <100.00%> (ø)
server/lib/scene/index.js 100.00% <100.00%> (ø)
server/lib/scene/scene.addScene.js 94.44% <100.00%> (+0.10%) ⬆️
server/lib/scene/scene.init.js 100.00% <100.00%> (ø)
server/lib/variable/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aff2d3...94d9700. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit b241a8e into master Aug 25, 2020
@Pierre-Gilles Pierre-Gilles deleted the add-timezone branch August 25, 2020 13:29
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
… used in scenes in the UI (GladysAssistant#856)

* Add timezone configuration in parameters in UI

* When the timezone is modified, the server reloads all scenes

* Translate configuration in UI

* Fix tests

* Add more tests to the scene.init function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant