Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeviceInRoom same feature bug #876

Merged

Conversation

NickDub-old
Copy link
Contributor

@NickDub-old NickDub-old commented Sep 4, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix this problem :
image

@NickDub-old NickDub-old force-pushed the fix-box-device-multi-features branch from ae83eb4 to bc1e4c6 Compare September 4, 2020 16:26
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #876 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   93.50%   93.50%           
=======================================
  Files         428      428           
  Lines        5607     5607           
=======================================
  Hits         5243     5243           
  Misses        364      364           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 529dec9...bc1e4c6. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit 5a398d0 into GladysAssistant:master Sep 7, 2020
@Pierre-Gilles
Copy link
Contributor

@all-contributors please add @NickDub for code

@allcontributors
Copy link
Contributor

@Pierre-Gilles

I've put up a pull request to add @NickDub! 🎉

@Pierre-Gilles
Copy link
Contributor

@all-contributors please add @NickDub for code

@allcontributors
Copy link
Contributor

@Pierre-Gilles

I've put up a pull request to add @NickDub! 🎉

@NickDub-old NickDub-old deleted the fix-box-device-multi-features branch November 5, 2020 12:48
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
Co-authored-by: Nicolas Dubois <nicolas.dubois@adeo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants