Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bluetooth] Service crash container at startup #916

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

atrovato
Copy link
Contributor

Fixes #898

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add global error handler.

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #916 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #916   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files         461      461           
  Lines        6149     6149           
=======================================
  Hits         5761     5761           
  Misses        388      388           
Impacted Files Coverage Δ
server/seeders/20190226025926-service.js 100.00% <ø> (ø)
server/utils/constants.js 100.00% <ø> (ø)
server/lib/service/service.start.js 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64c4c1...3503c59. Read the comment docs.

@atrovato atrovato force-pushed the atrovato/issue898 branch 4 times, most recently from 0516c4b to 9431fac Compare October 31, 2020 17:13
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited: my bad, I understand the fixes now I read too fast.

Be careful with the changeColumn again, it destroys the table!

server/migrations/20201031091221-service-reword-status.js Outdated Show resolved Hide resolved
@Pierre-Gilles Pierre-Gilles merged commit 5164a26 into GladysAssistant:master Nov 2, 2020
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…ladysAssistant#916)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@atrovato atrovato deleted the atrovato/issue898 branch November 28, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bluetooth] Service crash container at startup
2 participants