Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth device creation #921

Merged

Conversation

atrovato
Copy link
Contributor

@atrovato atrovato commented Nov 5, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • [ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • [ ] Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Prepares device creation/deletion actions on Bluetooth service

  • add more efficient logs
  • refactoring some code (requested by incoming Awox service).

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #921 (5d2cea4) into master (a821cfa) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   94.52%   94.62%   +0.10%     
==========================================
  Files         485      490       +5     
  Lines        6444     6494      +50     
==========================================
+ Hits         6091     6145      +54     
+ Misses        353      349       -4     
Impacted Files Coverage Δ
...bluetooth/lib/commands/bluetooth.connectDevices.js 100.00% <100.00%> (+12.50%) ⬆️
...etooth/lib/commands/bluetooth.getCharacteristic.js 100.00% <100.00%> (ø)
.../services/bluetooth/lib/commands/bluetooth.poll.js 100.00% <100.00%> (ø)
...ces/bluetooth/lib/commands/bluetooth.postCreate.js 100.00% <100.00%> (ø)
...ces/bluetooth/lib/commands/bluetooth.postDelete.js 100.00% <100.00%> (ø)
...ces/bluetooth/lib/commands/bluetooth.readDevice.js 100.00% <100.00%> (ø)
...ces/bluetooth/lib/commands/bluetooth.scanDevice.js 100.00% <100.00%> (+3.33%) ⬆️
...luetooth/lib/commands/bluetooth.subscribeDevice.js 100.00% <100.00%> (ø)
...etooth/lib/commands/bluetooth.unsubscribeDevice.js 100.00% <100.00%> (ø)
...es/bluetooth/lib/commands/bluetooth.writeDevice.js 100.00% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a821cfa...5d2cea4. Read the comment docs.

@atrovato atrovato force-pushed the bluetooth-device-creation branch 4 times, most recently from c1259aa to 49dc179 Compare November 6, 2020 06:10
@atrovato atrovato force-pushed the bluetooth-device-creation branch from 29f4f8c to 1877daf Compare November 28, 2020 09:40
@atrovato atrovato marked this pull request as ready for review November 28, 2020 13:41
@atrovato atrovato force-pushed the bluetooth-device-creation branch from 1877daf to ef63ad1 Compare November 30, 2020 19:56
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this is really great!

@Pierre-Gilles Pierre-Gilles merged commit 6f92880 into GladysAssistant:master Dec 3, 2020
@atrovato atrovato deleted the bluetooth-device-creation branch November 28, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants