Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #932 : fix start scene button in scene list #936

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Nov 9, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.json) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #936 (f2d481d) into master (15c063a) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   94.02%   94.22%   +0.19%     
==========================================
  Files         462      462              
  Lines        6130     6133       +3     
==========================================
+ Hits         5764     5779      +15     
+ Misses        366      354      -12     
Impacted Files Coverage Δ
server/api/websockets/index.js 56.66% <100.00%> (+23.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c063a...f2d481d. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit cedf198 into master Nov 9, 2020
@Pierre-Gilles Pierre-Gilles deleted the bugfixing branch November 9, 2020 15:23
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…ladysAssistant#931 websocket is not open bug (GladysAssistant#936)

* Fix GladysAssistant#932 : fix start scene button in scene list

* Fix GladysAssistant#931 : WebSocket is not open bug

* Add tests on Websocket manager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant