Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[philips-hue] Adding device LOM001 #941

Merged
merged 3 commits into from
Nov 11, 2020

Conversation

VonOx
Copy link
Contributor

@VonOx VonOx commented Nov 10, 2020

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)

Description of change

Fix #940 by adding device LOM001

@VonOx VonOx requested a review from Pierre-Gilles November 10, 2020 16:21
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #941 (c71970e) into master (9496cf6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #941   +/-   ##
=======================================
  Coverage   94.22%   94.22%           
=======================================
  Files         462      462           
  Lines        6133     6133           
=======================================
  Hits         5779     5779           
  Misses        354      354           
Impacted Files Coverage Δ
.../services/philips-hue/lib/light/light.getLights.js 97.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9496cf6...c71970e. Read the comment docs.

@Pierre-Gilles Pierre-Gilles merged commit e837997 into GladysAssistant:master Nov 11, 2020
R6n0 pushed a commit to R6n0/Gladys that referenced this pull request Dec 2, 2020
…sistant#941)

Co-authored-by: Pierre-Gilles Leymarie <pierregilles.leymarie@gmail.com>
@VonOx VonOx deleted the philips-hue branch April 20, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Philips Hue: Add device LOM001
2 participants