Github Workflows implementation #948
Conversation
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 462 462
Lines 6133 6133
=======================================
Hits 5779 5779
Misses 354 354 Continue to review full report at Codecov.
|
|
Nice! And how does it work for the dev build? With a manual trigger? |
Yep , Actions Tab and run job |
|
Amazing! Let me know when this is ready for review :) |
|
It's ready but if you merge we cant build i386 platform |
|
Ah yes alright. What's the next step for that then? is i386 used right now ? (I don't remember for which platform we build it?) |
|
Yes we build ( with circleci ) x86 images , I have no idea how many pulls but maybe for dev images it is acceptable to not have i386 images |
Which machines exactly are using those images ? It's maybe ok to drop support for this honestly, even more for dev images :) |
|
Some NAS I suppose and old 32bits processors Majority of running instance use arm I think ( we build arm v6/v7 and arm64 ). We maybe cover about 95% of the scope I removed the draft flag, you can see workflow running |
VonOx
changed the title
…adysAssistant#948) * Github Workflow for dev build * Workflow for building amd64 images on PR * Rename job * Revert to old node lts (12.x) * Update docker-dev-build.yml
This PR add 2 Github workflows/actions
docker-pr-build.yml
This workflow is triggered on no draft PR.
Here we build amd64 docker image without docker login and without pushing to DockerHub
docker-dev-build.yml
This one is a manual action
It build and push multi arch image to gladys:dev tag based on master branch.
Currently there is a bug in node alpine ( i386 is unavailable for building ) #947
Tested successfully in repo => https://github.com/VonOx/GLADYS_CI
@Pierre-Gilles like circle ci you need to set repo secrets: