Weather module

[callemand]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• Is the linter passing? (npm run eslint on both front/server)
• Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Based on "#504" but use openweather api.

Ajout du nom de la maison servant de point de géolocalisation
Ajout du taux d’humidité et de la vitesse du vent
Ajout des prévisions météo horaires pour les 8 prochaines heures avec icônes et températures
Ajout des prévisions météo horaires pour les 7 prochains jours avec icônes et températures min et max

Screenshots

[codecov]

Codecov Report

Merging #961 (ea2e3d1) into master (abb17b3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         485      485           
  Lines        6438     6438           
=======================================
  Hits         6085     6085           
  Misses        353      353           

Impacted Files	Coverage Δ
server/models/dashboard.js	100.00% <ø> (ø)
server/services/openweather/index.js	92.59% <100.00%> (ø)
server/services/openweather/lib/formatResults.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb17b3...ea2e3d1. Read the comment docs.

[Pierre-Gilles]

Hi !

Thanks for your pull request, it looks really nice and I'm looking forward to merge this in Gladys Assistant 👍

Just one question, are we losing the big weather icon like it was before?

Maybe it could be nice to still have it when it "compressed" mode?

Second question, it seems your PR is breaking the demo mode of Gladys Assistant (demo.gladysassistant.com)

Here is what I see in demo mode:

To test the demo mode, you need to create a .env file in your "front" folder, with the value:

DEMO_MODE=true

And restart locally the frontend.

Let me know if you have any questions, and again thank you very much for your work here 🙂

[callemand]

Hi !

Thanks for your pull request, it looks really nice and I'm looking forward to merge this in Gladys Assistant 👍

Thanks 👍

Just one question, are we losing the big weather icon like it was before?

Yes, but it's a mistake, it's fixed now

Maybe it could be nice to still have it when it "compressed" mode?
Yes, in compressed mode and all others mode

Second question, it seems your PR is breaking the demo mode of Gladys Assistant (demo.gladysassistant.com)

Here is what I see in demo mode:

To test the demo mode, you need to create a .env file in your "front" folder, with the value:

DEMO_MODE=true

And restart locally the frontend.

Let me know if you have any questions, and again thank you very much for your work here 🙂

It's fixed too, I didn't know the debug mode on the front

[atrovato]

I hope @Pierre-Gilles agree my comments.

[Pierre-Gilles]

That's some amazing work here 👏

Congrats for your great work, I'm merging this in Gladys right now!

[Pierre-Gilles]

@all-contributors please add @callemand for code

[allcontributors]

@Pierre-Gilles

I've put up a pull request to add @callemand! 🎉

[Pierre-Gilles]

@callemand could you maybe put a profile picture (or just an avatar, not necessarily your face) to your GitHub account? :)

So it looks better on the README: